Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource synch process for delete event #592

Merged
merged 1 commit into from
Nov 17, 2023
Merged

resource synch process for delete event #592

merged 1 commit into from
Nov 17, 2023

Conversation

huiwq1990
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

When use binding-apiserver, ondelete should keep object's origin infomation. As memorystorage need object's metadata information.

Which issue(s) this PR fixes:
Fixes #569

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@clusterpedia-bot
Copy link

Hi @huiwq1990,
Thanks for your pull request!
If the PR is ready, use the /auto-cc command to assign Reviewer to Review.
We will review it shortly.

Details

Instructions for interacting with me using comments are available here.
If you have questions or suggestions related to my behavior, please file an issue against the gh-ci-bot repository.

@clusterpedia-bot clusterpedia-bot added the kind/bug Something isn't working label Nov 15, 2023
Iceber
Iceber reviewed Nov 15, 2023
View reviewed changes
Copy link
Member

@Iceber Iceber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for going ahead and fixing this, but there are a few things that still need to be discussed

pkg/synchromanager/clustersynchro/resource_synchro.go Outdated Show resolved Hide resolved
pkg/synchromanager/clustersynchro/resource_synchro.go Outdated Show resolved Hide resolved
@Iceber
Copy link
Member

Iceber commented Nov 15, 2023 •
edited
Loading

Hi @huiwq1990 Are you guys using clusterpedia and would you mind if we communicate via wechat?

@huiwq1990
Copy link
Contributor Author

Hi @huiwq1990 Are you guys using clusterpedia and would you mind if we communicate via wechat?

ok, I will send my telephone via email.

Iceber
Iceber approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@Iceber Iceber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

But this also requires the memory storage layer to support PartialObjectMetadata, which of course may require other issues and pr to resolve

Also I think that not getting the resource version when deleting may have an effect on #593 as well.

@Iceber Iceber merged commit 630cf19 into clusterpedia-io:main Nov 17, 2023
7 checks passed
@Iceber Iceber mentioned this pull request Nov 20, 2023
Open
@huiwq1990 huiwq1990 deleted the bugfix-ondelete branch December 1, 2023 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Iceber Iceber Iceber approved these changes

Assignees
No one assigned
Labels
kind/bug Something isn't working size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

binding-apiserver could not delete pods
3 participants
@huiwq1990 @clusterpedia-bot @Iceber